Add GDPR parameters in ad request #2522

guillaume-sticky · 2018-05-11T14:24:33Z

Type of change

Bugfix
[ x] Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other

Description of change

Add some parameters support for freewheel-ssp bidder adapter.
Especially GDPR parameters to be transmit to our ad server

contact email of the adapter’s maintainer
gandouard@freewheel.tv
[ *] official adapter submission

Conflicts: src/adapters/stickyadstv.js test/spec/adapters/stickyadstv_spec.js

harpere

see comments. also, should add tests.

harpere · 2018-05-11T18:09:18Z

modules/freewheelSSPBidAdapter.js

@@ -223,6 +223,20 @@ export const spec = {
      componentId: getComponentId(currentBidRequest.params.format)
    };

+    if (typeof currentBidRequest.params.gdpr !== 'undefined') {


this wasn't done properly. buildRequests(bidRequests, bidderRequest) has a second bidderRequest argument where you'll find the gdpr params. please see the doc.

also, more specifically, I believe gdpr_consent could exist while gdpr is undefined. So checking gdpr !== 'undefined' is not a good way to do this.

Thx, I'll have a look.

Changes have been made, thx again.

jsnellbaker

Saw some additional changes that should be reviewed.

jsnellbaker · 2018-06-06T14:46:51Z

modules/freewheelSSPBidAdapter.js

+
+    var vastParams = currentBidRequest.params.vastUrlParams;
+    if (typeof vastParams === 'object') {
+      for (kye in vastParams) {


Seems to be a small typo here; believe it should be key

jsnellbaker · 2018-06-06T14:47:48Z

modules/freewheelSSPBidAdapter.js

+      requestParams._fw_gdpr_consent = bidderRequest.gdprConsent.consentString;
+
+      if (typeof currentBidRequest.gdprConsent.gdprApplies === 'boolean') {
+        requestParams._fw_gdpr = currentBidRequest.gdprConsent.gdprApplies;


Should update currentBidRequest to bidderRequest in these two lines of code.

mkendall07 · 2018-06-14T13:15:36Z

This pull request introduces 1 alert when merging 2a18f58 into 71503a7 - view on LGTM.com

new alerts:

1 for Missing variable declaration

Comment posted by LGTM.com

jsnellbaker

@guillaume-sticky Thanks for making the changes; LGTM now.

jsnellbaker · 2018-06-18T13:45:21Z

modules/freewheelSSPBidAdapter.js

+
+    var vastParams = currentBidRequest.params.vastUrlParams;
+    if (typeof vastParams === 'object') {
+      for (key in vastParams) {


Update - I thought this was addressed in the commit, but it seems it wasn't. The LGTM check noted this key variable isn't properly declared (missing a let). Could you update this spot?

jsnellbaker · 2018-06-18T14:02:51Z

@guillaume-sticky Please submit a docs PR in the docs repo and make an update in your bidders page to add the following variable.

gdpr_supported: true

This can go directly below the variable for your 1.0 compliance. This will allow your adapter to appear in a table that shows GDPR compliant adapters. Thanks.

guillaume-sticky · 2018-06-18T14:06:36Z

will do. Thx!

* add stickyadsTV bidder adapter * init unit test file * ad some unit tests * fix unit test on ad format with parameters * add some unit tests * add unit tests on getBid method * add some test cases in unit tests * minor fix on component id tag. * remove adapters-sticky.json test file * use top most accessible window instead of window.top * Pass in the bid request in the createBid call. * use top most accessible window instead of window.top * add unit tests * update unit tests * fix unit test. * fix CI build * add alias freewheel-ssp * update unit tests on bidderCode value * fix component id values and add unit tests * allws to use any outstream format. * fix ASLoader on futur outstream format versions * minor: fix code format. * update unit tests * minor fix code format * minor: add missing new line at eof * replace StickyAdsTVAdapter by freewheel ssp bd adapter (for prebid 1.0) * remove old stickyadstv unittest spec. * fix server response parsing if sent as object with 'body' field * use the vastXml field for video mediatype * add user sync pixel in freewheel ssp adapter * remove all console log calls (replaced using util helper) * remove useless bidderCode (automatically added by the bidderFactory) * Return the SYNC pixel to be added in the page by Prebid.js * remove instance level properties to enable concurrent bids with the same adapter instance. * fix the request apss through and corresponding unit tests * fix 'freeheelssp' typo * add vast parameters feature and GDPR params in VAST request * fix lint issues * add gdpr parameter support on freewheelSSPBidAdapter * use bidderrequest to read gdpr parameters and update unit tests * fix lint errors * fix lint errors * fix typo and bidderRequest reference. * fix bidderRequest reference. * add missing declaration for 'key' variable

guillaume-sticky and others added 30 commits January 5, 2017 10:21

add stickyadsTV bidder adapter

632c8c1

init unit test file

a91ac2d

ad some unit tests

9e2d70e

fix unit test on ad format with parameters

9c92c3e

add some unit tests

7ed68e9

add unit tests on getBid method

88a45ac

add some test cases in unit tests

7d6bf3c

minor fix on component id tag.

affdd67

remove adapters-sticky.json test file

654a473

Merge remote-tracking branch 'Prebid/master'

3b0760e

use top most accessible window instead of window.top

8c0f143

Pass in the bid request in the createBid call.

fd877dc

use top most accessible window instead of window.top

09f7348

Merge remote-tracking branch 'Prebid/master'

28a36a6

add unit tests

90264e8

update unit tests

29453af

fix unit test.

b664ee1

fix CI build

57c31a1

Merge remote-tracking branch 'Prebid/master'

2915576

Merge remote-tracking branch 'Prebid/master'

c5c41be

add alias freewheel-ssp

475eee3

Merge remote-tracking branch 'Prebid/master'

71bfaa1

update unit tests on bidderCode value

410ee00

Merge branch 'master' into master

8f7c947

Merge remote-tracking branch 'Prebid/master'

1d7be59

Conflicts: src/adapters/stickyadstv.js test/spec/adapters/stickyadstv_spec.js

fix component id values and add unit tests

b09dfdd

Merge remote-tracking branch 'Prebid/master'

d5e6d79

allws to use any outstream format.

d52df6f

fix ASLoader on futur outstream format versions

9ad2b7f

minor: fix code format.

427b45c

harpere requested changes May 11, 2018

View reviewed changes

harpere self-assigned this May 11, 2018

harpere added needs review needs update labels May 11, 2018

guillaume-sticky added 5 commits May 22, 2018 11:43

Merge remote-tracking branch 'Prebid/master'

b332946

add gdpr parameter support on freewheelSSPBidAdapter

d7f57f4

use bidderrequest to read gdpr parameters and update unit tests

1ad8abd

fix lint errors

447785f

fix lint errors

37d95fc

jsnellbaker requested changes Jun 6, 2018

View reviewed changes

jsnellbaker self-assigned this Jun 6, 2018

guillaume-sticky added 2 commits June 14, 2018 15:07

fix typo and bidderRequest reference.

0238d92

fix bidderRequest reference.

2a18f58

jsnellbaker approved these changes Jun 18, 2018

View reviewed changes

jsnellbaker requested changes Jun 18, 2018

View reviewed changes

add missing declaration for 'key' variable

de1de4b

jsnellbaker approved these changes Jun 18, 2018

View reviewed changes

jsnellbaker merged commit 2c19032 into prebid:master Jun 18, 2018

guillaume-sticky mentioned this pull request Jun 18, 2018

add gdpr support in freewheel bidder adapter prebid/prebid.github.io#838

Merged

bretg removed needs review needs update labels Jun 20, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add GDPR parameters in ad request #2522

Add GDPR parameters in ad request #2522

guillaume-sticky commented May 11, 2018 •

edited

Loading

harpere left a comment

harpere May 11, 2018

harpere May 11, 2018

guillaume-sticky May 14, 2018

guillaume-sticky May 22, 2018

jsnellbaker left a comment

jsnellbaker Jun 6, 2018

guillaume-sticky Jun 14, 2018

jsnellbaker Jun 6, 2018

guillaume-sticky Jun 14, 2018

mkendall07 commented Jun 14, 2018

jsnellbaker left a comment

jsnellbaker Jun 18, 2018

guillaume-sticky Jun 18, 2018

jsnellbaker commented Jun 18, 2018

guillaume-sticky commented Jun 18, 2018

Add GDPR parameters in ad request #2522

Add GDPR parameters in ad request #2522

Conversation

guillaume-sticky commented May 11, 2018 • edited Loading

Type of change

Description of change

harpere left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jsnellbaker left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mkendall07 commented Jun 14, 2018

jsnellbaker left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jsnellbaker commented Jun 18, 2018

guillaume-sticky commented Jun 18, 2018

guillaume-sticky commented May 11, 2018 •

edited

Loading